[FFmpeg-devel] [PATCH] flv duration

[Howard Chu]

Michael Niedermayer wrote:
> On Wed, Apr 07, 2010 at 08:28:51AM -0700, Howard Chu wrote:
>> Michael Niedermayer wrote:
>>> I see nothing in this patch that is correct.
>>
>> You should have said that up front and saved us both a lot of time.
>>
>>> Hiding a warning about estimated bitrate&duration by explicitly setting
>>> the bitrate incorrectly and thus changing a "might be wrong to a is wrong"
>>> isnt really an improvment.
>>
>> The patch sets the bitrate based on the metadata of the stream. You're
>> saying the metadata can't be trusted?
>
> iam saying the weight of a car is larger than the sum of its passangers
> weights, the car itself has weight too.
> Its the same with bitrates

Fair enough. Still, since you're setting the vcodec bitrate, it seems you 
ought to also be setting the acodec bitrate.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dif3.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100410/224f63f2/attachment.txt>