[FFmpeg-devel] [PATCH 1/6] Avoid the use of the symbol ff_expr_s for referencing AVEvalExpr.

[Michael Niedermayer]

On Sun, Apr 11, 2010 at 12:53:40PM +0200, Stefano Sabatini wrote:
> On date Sunday 2010-04-11 02:15:24 +0200, Michael Niedermayer encoded:
> > On Sun, Apr 11, 2010 at 01:05:31AM +0200, Stefano Sabatini wrote:
> > > On date Saturday 2010-04-10 13:50:28 +0200, Stefano Sabatini encoded:
> > > > ---
> > > >  libavcodec/eval.c |    4 ++--
> > > >  libavcodec/eval.h |    2 +-
> > > >  2 files changed, 3 insertions(+), 3 deletions(-)
> > > > 
> > > > diff --git a/libavcodec/eval.c b/libavcodec/eval.c
> > > > index 134c43f..2b1fe3c 100644
> > > > --- a/libavcodec/eval.c
> > > > +++ b/libavcodec/eval.c
> > > > @@ -115,7 +115,7 @@ static int strmatch(const char *s, const char *prefix){
> > > >      return 1;
> > > >  }
> > > >  
> > > > -struct ff_expr_s {
> > > > +struct AVEvalExpr {
> > > >      enum {
> > > >          e_value, e_const, e_func0, e_func1, e_func2,
> > > >          e_squish, e_gauss, e_ld,
> > > > @@ -130,7 +130,7 @@ struct ff_expr_s {
> > > >          double (*func1)(void *, double);
> > > >          double (*func2)(void *, double, double);
> > > >      } a;
> > > > -    AVEvalExpr * param[2];
> > > > +    struct AVEvalExpr *param[2];
> > > >  };
> > > >  
> > > >  static double eval_expr(Parser * p, AVEvalExpr * e) {
> > > > diff --git a/libavcodec/eval.h b/libavcodec/eval.h
> > > > index 5481b14..02dd117 100644
> > > > --- a/libavcodec/eval.h
> > > > +++ b/libavcodec/eval.h
> > > > @@ -47,7 +47,7 @@ double ff_eval2(const char *s, const double *const_value, const char * const *co
> > > >                 double (**func2)(void *, double, double), const char **func2_name,
> > > >                 void *opaque, const char **error);
> > > >  
> > > > -typedef struct ff_expr_s AVEvalExpr;
> > > > +typedef struct AVEvalExpr AVEvalExpr;
> > > >  
> > > >  /**
> > > >   * Parses a expression.
> > > 
> > > Ping.
> > 
> > rejected
> 
> Please elaborate, I have no problem at dropping this patch but I need
> to know *why*.

a subsequent patch renames AVEvalExpr to something else

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100411/038126e3/attachment.pgp>