[FFmpeg-devel] [PATCH] fix av_url_read_fseek

[Howard Chu]

Michael Niedermayer wrote:
> On Sat, Apr 10, 2010 at 06:57:09PM -0700, Howard Chu wrote:
>> Michael Niedermayer wrote:
>>> On Sat, Apr 10, 2010 at 04:37:36PM -0700, Howard Chu wrote:
>>>> Protocols that implement read_seek are unlikely to also implement seek,
>>>> so
>>>> this patch is needed to prevent the pos from getting set to a negative
>>>> value. Possibly it should just check for pos<= 0 instead of checking for
>>>> any specific error code. It's not clear that there's any real point to
>>>> calling seek here anyway, any stream that knows the value of SEEK_CUR
>>>> would
>>>> have already updated itself while executing the read_seek.
>>
>>> should that check not be<0 ?
>>
>> Probably. As I already noted above, I have a lot of doubts about this chunk
>> of code. Maybe better would be something like:
>>
>>    if (pos>= 0)
>>       s->pos = pos
>>    else if (pos != AVERROR(ENOSYS))
>>       ret = pos;
>>
>> I.e., if seek is actually implemented and fails, that probably should be
>> reported to the caller.
>
> what you say sounds reasonable at first glance

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dif.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100411/b2bd93be/attachment.txt>