[FFmpeg-devel] [PATCH] don't override file duration with bitrate guessed duration

[Michael Niedermayer]

On Tue, Apr 13, 2010 at 12:13:17AM +0200, elupus wrote:
> On Mon, 12 Apr 2010 15:37:00 +0000 (UTC), Carl Eugen Hoyos wrote:
> 
> > Joakim Plate <elupus <at> ecce.se> writes:
> > 
> >> [6 quoted lines suppressed]
> > 
> > Of course, but since the shown duration does not change, I wonder what the
> > correct description of the patch is.
> > 
> > Carl Eugen
> 
> Ah, i hadn't noticed that in av_estimate_timings_from_bit_rate it doesn't
> actually do anything when avfmt->duration had been set already. 
> 
> It even skips filling in the stream durations in that case, which leads to
> no stream actually getting any duration
> 
> So in effect the patch makes sure fill_all_stream_timings get's called
> which makes sure all streams have durations aswell as the full file.

but the stream durations can differ from each other, filling them in from
the file duration might not be that good of an idea

the bitrate would have been ok OTOH

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100413/c8580a35/attachment.pgp>