[FFmpeg-devel] [PATCH] H264: move avctx->refs init down to SPS (take 2)

Michael Niedermayer michaelni
Wed Apr 14 16:51:56 CEST 2010


On Wed, Apr 14, 2010 at 04:43:26PM +0200, Gwenole Beauchesne wrote:
> Hi,
>
> On Wed, 14 Apr 2010, Michael Niedermayer wrote:
>
>>> d2ac629f224aec2ba0fd9b8347d8adadf9d94448  ffmpeg.h264.refs.patch
>>> commit 837dcdec35c721f5c56dcbbc31e2290957c3e2b1
>>> Author: Gwenole Beauchesne <gbeauchesne at splitted-desktop.com>
>>> Date:   Wed Apr 14 07:10:35 2010 +0200
>>>
>>>     Move avctx->refs initialization down to SPS.
>>
>> this patch is incorrect there can be several SPS, you wont know before
>> the slice header which is used.
>
> OK, I see. What about this one? It just moves avctx->refs init up, just 
> below h->sps is initialized.
>
> Thanks,
> Gwenole.

>  h264.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 9fafebf6053381920e7a56f8c86fe2777ad98a24  ffmpeg.h264.refs.2.patch
> commit df69f5f5d677dd6ac5fa94e4f67b8a8eecb6cc95
> Author: Gwenole Beauchesne <gbeauchesne at splitted-desktop.com>
> Date:   Wed Apr 14 14:12:23 2010 +0200
> 
>     Move avctx->refs init before AVCodecContext.get_format().

that should be ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100414/1e318730/attachment.pgp>



More information about the ffmpeg-devel mailing list