[FFmpeg-devel] [PATCH] Clip-wrapped MXF support (new attempt)

[Baptiste Coudurier]

On 04/15/2010 03:52 AM, Maksym Veremeyenko wrote:
> Baptiste Coudurier ???????(??):
>> Hi,
>>
>> On 04/14/2010 06:57 AM, Maksym Veremeyenko wrote:
> [...]
>>> *0006-clip-wrapped-support-added.patch*
>>> actually adds clip-wrapped code.
>>
>> Can you please isolate the clip wrapping reading code in another
>> function ?
> give me a hint, even if i create another function it will duplicate a
> lot of code from origin. The goal was to utilize more code with minor
> changes...
>
>> Also, there will be interleaving problems when done this way.
>  > This will extract one whole track then the other track.
>  > No player can reasonably buffer that much data.
>
> Yes, is possible but i think in a theoretical case, like described on
> page 378 of *MXF Book*, where clip-wrapped video track and
> clip/frame-wrapped audio track stored in mxf. That will require force
> interleaving like in avidec.c. Hence no samples for such case exists
> that could be implemented later....
>
> Anyway, for most cases clip-wrapped mxf contains only one track....
>

Did you miss something called op1b ?
That is not a theoretical case at all...

If the code only supports one track, then please add a check to ensure this.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org