[FFmpeg-devel] [PATCH] grayalpha pixfmt + support in pngdec

Michael Niedermayer michaelni
Mon Apr 19 00:57:13 CEST 2010


On Sun, Apr 18, 2010 at 09:36:22PM +0200, Stefano Sabatini wrote:
> On date Tuesday 2010-04-13 12:21:47 +0200, Michael Niedermayer encoded:
> > On Tue, Apr 13, 2010 at 10:34:48AM +0200, Andreas ?man wrote:
> > > Kostya wrote:
> > >> On Tue, Apr 13, 2010 at 09:33:51AM +0200, Andreas ?man wrote:
> > >>> Michael Niedermayer wrote:
> > >>>> On Mon, Apr 12, 2010 at 09:40:03PM +0200, Andreas ?man wrote:
> > >>>>> Michael Niedermayer wrote:
> > >>>>>> On Mon, Apr 12, 2010 at 10:43:02AM +0200, Andreas ?man wrote:
> > >>>>>>> Hi
> > >>>>>>> +    [PIX_FMT_GRAYALPHA] = {
> > >>>>>>> +        .name = "grayalpha",
> > >>>>>> where does the name grayalpha come from?
> > >>>>> I just didn't come up with anything better.
> > >>>>> Ideas are most welcome.
> > >>>> something that is consistent with existing formats would
> > >>>> be better also what is it calld in the png docs?
> > >>> PNG docs seems to call it "Grayscale with alpha" or "ya".
> > >>> Perhaps "ya" would be a good name then?
> > >> Nej, it obviously stands for "Y(aka luma) + A(alpha)"
> > >> i.e. not so good acronym.
> > >
> > > Kostya suggested "Y400A" on IRC.
> 
> I'm not very happy with this name, "4XX" notation only makes sense
> when we have three components, in this case I would have preferred
> something of the kind GRAY8ALPHA8 or GRAYALPHA8 (consistent with
> GRAY8), even YA was not that bad.

GRAY*ALPHA* is inconsistent with the existing naming and gray8 is quite
alone and the exception, not a good example to copy.


> 
> Not that I consider this a big issue, we will eventually fix the names
> at the next major bump.

The naming is good and reasonable consistent. To change it at the next maj ver
bump there needs to be a problem in the existing naming and a better naming and
consensus amongth the devels that the new is better and not just the yearly
bikeshed style. Because every such change means everyone will have to update
their applications and this is a lot of work when one considers how many
applications there are. Not to mention the ones that try to support differnent
lav* versions


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100419/0d3500a1/attachment.pgp>



More information about the ffmpeg-devel mailing list