[FFmpeg-devel] [PATCH 06/21] Make av_set_string3() check in the list of named constants before to try to evaluate the string to set with ff_eval2().

[Michael Niedermayer]

On Mon, Apr 19, 2010 at 12:37:57AM +0200, Stefano Sabatini wrote:
> On date Saturday 2010-04-17 23:45:44 +0200, Michael Niedermayer encoded:
> > On Sun, Apr 11, 2010 at 01:00:29AM +0200, Stefano Sabatini wrote:
> > > Avoid a spurious log error message issued by a call to ff_eval2() in
> > > the case where the string to set is a named constant.
> > 
> > do you have a testcase that shows this bug?
> 
> This is related to the ff_parse_expr() interface change, which makes
> the function log an error rather than fill an error string pointer.
> 
> The problem shows up everytime we use av_set_string3(): if the value
> for the string is a named value, the evaluation, which is performed
> *before* the check for named values, will issue a log error message.

i suspected this


> 
> My fix is to perform the check for named values *before* to evaluate
> the string, and just if that fails try to perform evaluation.

iam seeing it like that your change to the eval API introduces shortcommings
that restrict how eval can be used. Iam against such changes to eval

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100419/66a6196f/attachment.pgp>