[FFmpeg-devel] [PATCH] ffprobe: fix sample aspect ratio output when sample aspect ratio is not set

Robert Krüger krueger
Mon Apr 19 10:25:28 CEST 2010


On 16.04.2010, at 18:40, Robert Kr?ger wrote:

> 
> On 16.04.2010, at 18:16, Michael Niedermayer wrote:
> 
>> On Thu, Apr 15, 2010 at 03:05:30PM +0200, Robert Kr?ger wrote:
>>> 
>>> On 15.04.2010, at 14:02, Michael Niedermayer wrote:
>>> 
>>>> On Thu, Apr 15, 2010 at 01:16:05PM +0200, Robert Kr?ger wrote:
>> 
> 
> You're probably right although I would suspect that there are tons of programs out there which parse the output of ffmpeg to determine the display size of the video which will have an incorrect result here but that's beside the point, I know. What I would like someone to decide is how ffprobe should communicate the sample aspect ratio (and consequently the display aspect ratio as well) not being available (i.e. numerator being zero, at least that criterion is used in other places in ffmpeg code)
> 
> 1) output "N/A" for both values
> 2) don't output those key value pairs at all
> 3) output what's in the struct (e.g. 0:1 in my case) for both like it does now
> 
> I think 3 does not make sense and would submit a patch for 1 or 2 if someone (Stefano or you?) tells me which. 

ping, Stefano?




More information about the ffmpeg-devel mailing list