[FFmpeg-devel] [PATCH 1/4] mov: Read nero chapters

[Baptiste Coudurier]

On 04/19/2010 10:24 AM, David Conrad wrote:
> ---
>   libavformat/mov.c |   20 ++++++++++++++++++++
>   1 files changed, 20 insertions(+), 0 deletions(-)
>
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index aaaa587..35c7575 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -219,6 +219,25 @@ static int mov_read_udta_string(MOVContext *c, ByteIOContext *pb, MOVAtom atom)
>       return 0;
>   }
>
> +static int mov_read_chpl(MOVContext *c, ByteIOContext *pb, MOVAtom atom)
> +{
> +    int i, nb_chapters, str_len;
> +    char str[256+1];
> +
> +    get_be32(pb); // version + flags
> +    get_be32(pb); // ???
> +    nb_chapters = get_byte(pb);
> +
> +    for (i = 0; i<  nb_chapters; i++) {
> +        int64_t start = get_be64(pb);
> +        str_len = get_byte(pb);
> +        get_buffer(pb, str, str_len);
> +        str[str_len] = 0;
> +        ff_new_chapter(c->fc, i, (AVRational){1,10000000}, start, AV_NOPTS_VALUE, str);
> +    }

Can you check the size you're going to read against the parent atom.size ?

We already had one issue about that.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org