[FFmpeg-devel] [RFC] Removing non-pthreads support

[Ramiro Polla]

On Tue, Apr 20, 2010 at 6:50 PM, Gianluigi Tiesi <mplayer at netfarm.it> wrote:
> On Tue, Apr 20, 2010 at 05:20:09PM +0100, M?ns Rullg?rd wrote:
>> Gianluigi Tiesi <mplayer at netfarm.it> writes:
>> > On Mon, Apr 19, 2010 at 11:29:44PM -0300, Ramiro Polla wrote:
>> >> this is my latest patch against pthreads-win32 CVS 20091019. compiles
>> >> and links and works fine with both gcc and msvc (the later was asked
>> >> by an ffms2 dev) and any combination of those 2. what it does is:
>> >> - remove the false wsock32 dependency
>> >
>> > the dep is not false :D
>>
>> How the f*ck does a threading library end up depending on a socket
>> library?
>
>
> void * pthread_getspecific (pthread_key_t key)
>
> int lasterror = GetLastError ();
> int lastWSAerror = WSAGetLastError ();
> ptr = TlsGetValue (key->key);
> SetLastError (lasterror);
> WSASetLastError (lastWSAerror);

Right, and my patch does
     {
       int lasterror = GetLastError ();
-      int lastWSAerror = WSAGetLastError ();

       ptr = TlsGetValue (key->key);

       SetLastError (lasterror);
-      WSASetLastError (lastWSAerror);
     }

Now where's the WSA dependency? If you wish you may also add a GDI
dependency there, it will still be a false dependency.

I'm still waiting for your reproducible testcase which proves those
lines are necessary...