[FFmpeg-devel] [RFC] Add IFF-ANIM decoder to Makefile and all that stuff...

[Michael Niedermayer]

On Wed, Apr 21, 2010 at 05:41:53PM +0200, Sebastian Vater wrote:
> Hey to all!
> 
> So now my latest patch for IFF-ANIM.
> 
> The following stuff has been changed/added:
> 
> Added EHB support.
> Added decoder stubs for IFF-ANIM-0 to 8 and IFF-ANIM-K.
> 
> Please note that reading the ANHD chunk is intentionally broken (to stop the IFF parsing so I'm able to watch the first image, otherwise it would disappear too fast).
> 
> IFF-ANIM now opens a window showing a garbarge image right now (missing decoder stuff), unless it's a HAM6/HAM8 movie which isn't supported yet.
> 
> Apart from this, all (hopefully) of critics have been applied to the code. Please comment on this one!
> 
[...]
> Index: ffmpeg-svn/libavcodec/avcodec.h
> ===================================================================
> --- ffmpeg-svn/libavcodec/avcodec.h	(r?vision 22931)
> +++ ffmpeg-svn/libavcodec/avcodec.h	(copie de travail)

> @@ -210,6 +210,16 @@
>      CODEC_ID_IFF_BYTERUN1,
>      CODEC_ID_KGV1,
>      CODEC_ID_YOP,
> +    CODEC_ID_IFF_ANIM,
> +    CODEC_ID_IFF_ANIM1,
> +    CODEC_ID_IFF_ANIM2,
> +    CODEC_ID_IFF_ANIM3,
> +    CODEC_ID_IFF_ANIM4,
> +    CODEC_ID_IFF_ANIM5,
> +    CODEC_ID_IFF_ANIM6,
> +    CODEC_ID_IFF_ANIM7,
> +    CODEC_ID_IFF_ANIM8,
> +    CODEC_ID_IFF_ANIMJ,

are these really distinct codecs?
also avctx->codec_id cannot change during a video.


[...]

>              url_fskip(pb, 12);
>              st->codec->sample_rate = get_be16(pb);
> -            url_fskip(pb, 1);
> -            compression            = get_byte(pb);
> -            url_fskip(pb, 4);
> +
> +            data_size_skip -= 14;
> +
> +            if (data_size >= 16) {
> +                url_fskip(pb, 1);
> +                compression            = get_byte(pb);
> +
> +                data_size_skip -= 2;
> +            }

reindentions mixed with functional changes make patches hard to review.


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100421/0aa1940c/attachment.pgp>