[FFmpeg-devel] [PATCH] Optimization of original IFF codec

Ronald S. Bultje rsbultje
Sun Apr 25 22:01:52 CEST 2010


Hi,

On Sun, Apr 25, 2010 at 3:56 PM, Sebastian Vater
<cdgs.basty at googlemail.com> wrote:
> Ok you're right, have fixed it!
[..]
> -            } else { // PIX_FMT_BGR32
> +            buf += s->planesize;
> +        }
> +    }
> +    } else { // PIX_FMT_BGR32

The indenting of the first 3 new lines is off by 4 (there should be 4
more spaces each).

>                      decodeplane8(row, s->planebuf, s->planesize, avctx->bits_per_coded_sample, plane);
> -                } else { //PIX_FMT_BGR32
> +                    }
> +                }
> +        } else { // PIX_FMT_BGR32

I'm not sure if the indenting is off here in the same way, could you check that?

Also, feel free to send a cosmetic patch to fix indenting (separately)
along with your next patch, this patch looks fine along for these
minor things and then I'll apply both at once.

Ronald



More information about the ffmpeg-devel mailing list