[FFmpeg-devel] [PATCH] Optimization of original IFF codec

[Sebastian Vater]

Hi Ronald!

Ronald S. Bultje a ?crit :
> Hi,
>
> On Sun, Apr 25, 2010 at 12:47 PM, Sebastian Vater
> <cdgs.basty at googlemail.com> wrote:
>   
>> So, here are the two patches seperated.
>>
>> Now comes the micro-op patch as requested by Mans...
>>     
> [..]
>   
>> +    const unsigned b = (buf_size * 8) + bps - 1; \
>>     
>
> Shouldn't be const, I think (?).
>   
Of course this should be const, since it isn't going to be changed. I
moved this just out of the for, because gcc was too stupid to do the
calculation outside of the loop.
>> +    for(i = 0; i < b; i++) { \
>> +        dst[ i ] |= get_bits1(&gb) << plane; \
>>     
> No spaces around "i".
>   
Already fixed, see my reply to Mans on this including fixed patch...
> Rest seems OK to me.
>
> Ronald
>   
-- 

Best regards,
                   :-) Basty/CDGS (-: