[FFmpeg-devel] [PATCH 4/4] Use an AVMetadata struct for storing metadata, simplify.

Michael Niedermayer michaelni
Mon Apr 26 00:13:42 CEST 2010


On Sat, Apr 24, 2010 at 03:34:17PM +0200, Stefano Sabatini wrote:
> ---
>  ffmpeg.c |   17 ++++++-----------
>  1 files changed, 6 insertions(+), 11 deletions(-)

an interresting patch, i dont see an immedeate problem so it
might be ok just keep in mind AVMetadata is not public API so it can
only ne used as an opaque pointer

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100426/ef5f4033/attachment.pgp>



More information about the ffmpeg-devel mailing list