[FFmpeg-devel] [PATCH] DCA floating point output

Michael Niedermayer michaelni
Mon Apr 26 10:16:51 CEST 2010


On Mon, Apr 26, 2010 at 10:55:40AM +0300, Kostya wrote:
> On Mon, Apr 26, 2010 at 09:45:49AM +0200, Benjamin Larsson wrote:
> > FB2000 skrev 2010-04-26 07:30:
> >> On Mon, Apr 26, 2010 at 1:06 PM, Kostya<kostya.shishkov at gmail.com>  wrote:
> >>
> >>    
> >>> Looking at the discussion here, patch is rejected until there's some
> >>> more or less unanimous opinion on floating-point output for generic
> >>> decoders.
> >>>
> >>>
> >>>      
> >> I think floating-point output for DCA is especially necessary since we
> >> already have float samples decoded. And it looks unwise to truncate to 16
> >> bit at all.
> >>
> >>    
> >>> Scaling can be merged somewhere and maybe
> >>> planar audio output will become a reality one day.
> >>>
> >>>      
> >> Unfortunately I don't know of a good place to merge the scaling, either.
> >>
> >>    
> >>> For now, sorry, no luck.
> >>>
> >>>      
> >> That's OK. I was just trying to be helpful.
> >>    
> >
> > Merge the scaling and patch is approved by DCA maintainer 1.
> 
> DCA maintainer 0 hint: s->scale_bias = 1.0 / 32768.0 may do the trick

ffmpeg maintainer 1 also approves the patch

and id also be happy if we would be moving to planar audio rather
sooner than later but thats no reason to hold this patch up.



[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100426/5e394c4d/attachment.pgp>



More information about the ffmpeg-devel mailing list