[FFmpeg-devel] [PATCH] ffprobe: fix sample aspect ratio output when sample aspect ratio is not set

[Stefano Sabatini]

On date Friday 2010-04-23 08:48:25 +0200, Robert Kr?ger encoded:
> On 23.04.2010, at 01:37, Stefano Sabatini wrote:
> > On date Wednesday 2010-04-21 02:11:16 +0200, Stefano Sabatini encoded:
[...]
> >> Today I tried to figure out which is better between N/A and no
> >> printing at all, both solutions have their pros and cons, but at the
> >> end I slightly prefer the "N/A" solution as it conveys more
> >> information to the human reader, same for the other nb_frames pending
> >> patch.
> > 
> > After more thought:
> > 1) 0:N with N != 0 is unknown
> > 2) N:0 is undefined / Non/Acceptable = N/A
> > 
> > For the case 1) we may either don't print at all either print
> > "unknown" like it is done in other cases, so I tend to prefer this for
> > consistency, but I'd like to hear other opinions before to apply that
> > solution.
> 
> Hmm, I interpreted "N/A" as not available
> (http://en.wikipedia.org/wiki/N/A), i.e. unknown, and I do not think
> that another state is required or meaningful/intuitive. IMHO in all
> cases I have seen in ffprobe a value is either not available
> (unknown) for whatever reason (not implemented, or not there by
> definition, e.g. because the codec/container format doesn't provide
> it) or it is there. It makes sense to treat the unknown case
> consistently (not print the key value pair, print "N/A" or print
> "unknown") but IMHO not to differentiate between subcases of
> unknown.
> 
> My 2c.

Applied a simpler variant without the N/A.

Thanks, happy ffprobing!
-- 
FFmpeg = Foolish and Fostering Mean Proud Ephemeral Goblin