[FFmpeg-devel] [PATCH] Reimplementation of OS/2 threads model

[KO Myung-Hun]

M?ns Rullg?rd wrote:
> KO Myung-Hun <komh at chollian.net> writes:
> 
>> M?ns Rullg?rd wrote:
>>> Ramiro Polla <ramiro.polla at gmail.com> writes:
>>>
>>>> On Wed, Apr 28, 2010 at 11:45 AM, KO Myung-Hun <komh at chollian.net> wrote:
>>>>> But now pthreads codes are in os2thread.c, so pthread lib is
>>>>> unnecessary. And we can use all the codes of pthread.c without modifying
>>>>> it at all. If possible, I would like to use '#include "pthread.c"' using
>>>>> some guard macros. This reduces the maintenance burden you are saying.
>>>>
>>>> Could you not make that code a simple library with a subset of
>>>> pthreads that ffmpeg needs? You could then link against that library
>>>> with the current pthreads code in FFmpeg.
>>>
>>> But a perfectly good pthread library _already exists_.  Why can't we
>>> just link to that instead of duplicating the effort.
>>>
>>
>> I don't understand correctly what you mean by 'perfectly good'. It is
>> also a subset of pthreads to support MySQL for OS/2.
> 
> If the existing one is missing something, improve it rather than
> creating another half-arsed version.
> 
>> And we can get two gains at least. One is a less size. The other is the
>> less dependency.
> 
> Depending on typical system libraries is perfectly OK.  Duplicating
> them is not.
> 
>> Nevertheless, why do you think that this is just the duplication ?
> 
> Because it is.  You are duplicating the functionality of the existing
> pthread library.  That's silly.
> 

Absolutely you're right if pthread lib is installed by default on OS/2.
Unfortunately, however, it is not. If it was so, I didn't start this
thread at all.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0.3
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr