[FFmpeg-devel] [PATCH] Add IFF metadata handling

[Vladimir Pantelic]

Sebastian Vater wrote:
> Vladimir Pantelic a ?crit :
>>  Sebastian Vater wrote:
>>>  Hi guys!
>>>
>>>  Just did a small patch which adds new IFF metadata stuff.
>>>
>>>  The original IFF demuxer just processed the comment metadata stuff,
>>>  therefore I added title, copyright and author metadata stuff to IFF
>>>  demuxer.
>>>
>>>  It's really a small patch and shouldn't be of any problems.
>>>
>>
>>  +            buf = av_malloc(data_size + 1);
>>  +            if (!buf)
>>  +                break;
>>  +            get_buffer(pb, buf, data_size);
>>  +            buf[data_size] = 0;
>>
>>  could be factored out
>
> Factored out? Do you mean putting it into a #define and just call the
> define's?

what is wrong with a function?