[FFmpeg-devel] [PATCH] Add IFF metadata handling

[Vladimir Pantelic]

Sebastian Vater wrote:
> Anton Khirnov a ?crit :
>>  On Fri, Apr 30, 2010 at 02:14:03PM +0200, Sebastian Vater wrote:
>>
>>>  +
>>>  +        case ID_AUTH:
>>>  +            buf = get_metadata(pb, data_size);
>>>  +            if (!buf)
>>>  +                break;
>>>  +            av_metadata_set2(&s->metadata, "author", buf, AV_METADATA_DONT_STRDUP_VAL);
>>>  +            break;
>>>
>>  Correct generic tagname is 'artist', see list in avformat.h. (or add a
>>  conv table)
>>
>
> Fixed!

why not roll these 3 lines into get_metadata() as well?

+            if (!buf)
+                break;
+            av_metadata_set2(&s->metadata, "author", buf, AV_METADATA_DONT_STRDUP_VAL);