[FFmpeg-devel] [PATCH] FLAC parser

Justin Ruggles justin.ruggles
Sun Aug 1 18:59:50 CEST 2010


Hi,

Michael Chinen wrote:

> Hi,
> 
> Thanks Justin and Diego, these were good suggestions, and I've put
> them all in, attached here (don't forget to apply the original second
> patch if you are testing on ffplay.)

There seems to be something still not working correctly.  I have a
perfectly valid flac file that passes "flac -t" but the parser skips 3
places that it thinks are junk frames and leads to 3 places with
multiple frames per packet.  It also segfaults in the decoder at the
last frame (the buffer size is correct but apparently not the buffer
pointer).

I'll try to see if I can figure out where it's going wrong, but I
decided to go ahead and point it out to you now so you can do more testing.

-Justin



More information about the ffmpeg-devel mailing list