[FFmpeg-devel] [PATCH] VP8 link error fix

[Ronald S. Bultje]

Hi,

On Tue, Aug 3, 2010 at 4:43 PM, Stefan Gehrer <stefan.gehrer at gmx.de> wrote:
> On 08/03/2010 09:58 PM, Frank Barchard wrote:
>>
>> On Tue, Aug 3, 2010 at 5:11 AM, Diego Biurrun<diego at biurrun.de> ?wrote:
>>>
>>> On Mon, Aug 02, 2010 at 08:32:09PM -0700, Frank Barchard wrote:
>>>>
>>>> A minor link error fix. ?libavcodec/Makefile needs vp56dsp.o now
>>>
>>> Rejected. ?You provide no error message nor a means to reproduce the
>>> problem.
>>
>> I see ffmpeg is now fixed in a better way, with vp8dsp instead of vp56dsp.
>> OBJS-$(CONFIG_VP8_DECODER) ? ? ? ? ? ? += vp8.o vp8dsp.o
>>
>> But theres a new problem, reproduced with the same configure:
>>
>> ./configure --disable-everything --disable-decoders
>> --disable-protocols --disable-parsers --disable-avfilter
>> --enable-avcore --disable-avdevice --disable-ffmpeg --disable-ffplay
>> --disable-ffserver --disable-ffprobe --enable-shared --disable-static
>> --disable-debug --disable-network --disable-gpl --disable-bzlib
>> --disable-zlib --enable-decoder=theora --enable-decoder=vorbis
>> --enable-demuxer=ogg --enable-pthreads --enable-yasm
>> --enable-memalign-hack --cc=gcc-sjlj --prefix=./chromium8-ffmpeg
>> --enable-decoder=vp8 --enable-demuxer=matroska
>> make
>> ...
>> ? ?Creating library libavcore/avcore-0.lib and object
>> libavcore/avcore-0.exp
>> LD ? ? ?libavcodec/avcodec-52.dll
>> Info: resolving _av_reverse by linking to __imp__av_reverse (auto-import)
>> Info: resolving _av_pix_fmt_descriptors by linking to
>> __imp__av_pix_fmt_descriptors (auto-import)
>> Creating library file: libavcodec/libavcodec.dll.a
>> libavcodec/vp8.o:vp8.c:(.text+0x1e): undefined reference to
>> `ff_h264_norm_shift'
>> libavcodec/vp8.o:vp8.c:(.text+0x83): undefined reference to
>> `ff_h264_norm_shift'
>> libavcodec/vp8.o:vp8.c:(.text+0xef): undefined reference to
>> `ff_h264_norm_shift'
>> libavcodec/vp8.o:vp8.c:(.text+0x145): undefined reference to
>> `ff_h264_norm_shift'
>> libavcodec/vp8.o:vp8.c:(.text+0x1b0): undefined reference to
>> `ff_h264_norm_shift'
>> libavcodec/vp8.o:vp8.c:(.text+0x220): more undefined references to
>> `ff_h264_norm_shift' follow
>> collect2: ld returned 1 exit status
>> make: *** [libavcodec/avcodec-52.dll] Error 1
>>
>> So the quick fix is add cabac.o to vp8's dependencies.
>
> Strange, I added that dependency in r23915, must have gone lost.

Diego (I think?) removed it recently.

Ronald