[FFmpeg-devel] [PATCH] G.723.1 Decoder

[Mohamed Naufal]

On 5 August 2010 13:40, Diego Biurrun <diego at biurrun.de> wrote:
>
> On Wed, Aug 04, 2010 at 08:21:33PM +0530, Mohamed Naufal wrote:
> >
> > Will update Changelog, version numbers and other stuff after approval.
>
> The patch will not be approved without them, so you are putting
> yourself in a catch-22 situation. ?Just add them now, it will not
> take more than 15 minutes of your time.


Fixed.

[...]


>
> I have no idea where this license header comes from, but it's bogus.
> Use our standard license header please.


Had copied it from a 2006 version of a file. Fixed.


>
> > +/**
> > + * @file
> > + * G723.1 compatible decoder data tables
> > + */
>
> This header is missing at least a stdint.h #include, please make sure
> it passes 'make checkheaders'.


Fixed.

>
> > --- /dev/null
> > +++ b/libavcodec/g723_1.c
> > @@ -0,0 +1,1072 @@
> > +/*
> > + * G.723.1 compatible decoder.
>
> Drop the trailing period (in other places as well).
>


Fixed.

>
> > + ? ? ? ?buf[i] ? ? = av_clip_int16((buf[i] * (p->pf_gain + (p->pf_gain >> 4)) +
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?(1 << 10)) >> 11);
>
> Indentation is off.


Fixed.

[...]


Thanks,
Naufal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: synth_filter.patch
Type: text/x-patch
Size: 2534 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100805/91ab09f2/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: data_tables.patch
Type: text/x-patch
Size: 78194 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100805/91ab09f2/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: decoder.patch
Type: text/x-patch
Size: 37089 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100805/91ab09f2/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: demuxer.patch
Type: text/x-patch
Size: 4463 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100805/91ab09f2/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: doc.patch
Type: text/x-patch
Size: 824 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100805/91ab09f2/attachment-0004.bin>