[FFmpeg-devel] [PATCH] Resize data and linesize in AVFilterBufferRef to 8 and supporting changes

Michael Niedermayer michaelni
Mon Aug 9 14:04:34 CEST 2010


On Thu, Aug 05, 2010 at 02:59:52AM -0700, S.N. Hemanth Meenakshisundaram wrote:
> Replaced a av_picture_copy call in ffplay.c with av_picture_data_copy.
> Otherwise same patch.
> 
> ---
>  ffmpeg.c                  |    4 ++--
>  ffplay.c                  |    4 ++--
>  libavfilter/avfilter.h    |    4 ++--
>  libavfilter/vsrc_buffer.c |    4 ++--
>  4 files changed, 8 insertions(+), 8 deletions(-)
> 
> 
> 

>  ffmpeg.c                  |    4 ++--
>  ffplay.c                  |    4 ++--
>  libavfilter/avfilter.h    |    4 ++--
>  libavfilter/vsrc_buffer.c |    4 ++--
>  4 files changed, 8 insertions(+), 8 deletions(-)
> 9866b1362915e20ac42c7a64b92512a9b69d70ab  0001-Resize-data-and-linesize-in-AVFilterBufferRef-to-8-a.patch
> diff --git a/ffmpeg.c b/ffmpeg.c
> index 07017ed..6484828 100644
> --- a/ffmpeg.c
> +++ b/ffmpeg.c
> @@ -377,8 +377,8 @@ static int get_filtered_video_pic(AVFilterContext *ctx,
>  
>      *pts          = pic->pts;
>  
> -    memcpy(pic2->data,     pic->data,     sizeof(pic->data));
> -    memcpy(pic2->linesize, pic->linesize, sizeof(pic->linesize));
> +    memcpy(pic2->data,     pic->data,     4*sizeof(pic->data[0]));
> +    memcpy(pic2->linesize, pic->linesize, 4*sizeof(pic->linesize[0]));

FFMIN(sizeof(pic->data), sizeof(pic2->data))
also the variable names pic and pic2 are poorly choosen, seperate issue though


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100809/bd92d7b4/attachment.pgp>



More information about the ffmpeg-devel mailing list