[FFmpeg-devel] [patch]add mmsh protocol and extract common code for mmst.c

zhentan feng spyfeng
Mon Aug 9 18:05:07 CEST 2010


hi

On Sat, Aug 7, 2010 at 12:44 AM, zhentan feng <spyfeng at gmail.com> wrote:

> Hi
>
> On Wed, Aug 4, 2010 at 12:15 AM, Ronald S. Bultje <rsbultje at gmail.com>wrote:
>
>> Hi Zhentan,
>>
>> On Tue, Aug 3, 2010 at 11:49 AM, zhentan feng <spyfeng at gmail.com> wrote:
>> > #1 patch is extracted common code from mmst.c into mms.c and mms.h to be
>> > used by mmsh.c
>>
>> - MMSContext should be embedded in MMSTContext, it shouldn't be a
>> pointer as it is now. If you need a pointer, use &mmst->mms.
>> - don't call the variable (in functions) mmst_ctx. Just mmst is fine.
>> We know it's a context from the type. If you call it mms, you get the
>> added benefit of not having to change each function call and function
>> header, so I'd go for that.
>> - There is no reason why you would move the definition in mmst.c,
>> right now you're moving it, causing every line within MMS.Context to
>> appear in the diff. There is no reason for this.
>>
>
>
> #4 patch extract common fields from MMSTContext into  MMSContext for the
> later patch for mmsh.c
> #5 is for vertical alignment
>
>

#6 patch is for extract common code from mmst.c
#7 along with #6, this patch add the common code to mms.h and mms.c
#8 patch is the modification for libavformat/Makefile for mmsh.c
#9 adds mmsh.c

zhentan

-- 
Best wishes~
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 6_extract_fun.patch
Type: application/octet-stream
Size: 7053 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100810/5eb52804/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 7_add_mms_ch.patch
Type: application/octet-stream
Size: 7713 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100810/5eb52804/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 8_Makefile_for_mmsh.patch
Type: application/octet-stream
Size: 549 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100810/5eb52804/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 9_add_mmsh.patch
Type: application/octet-stream
Size: 12905 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100810/5eb52804/attachment-0003.obj>



More information about the ffmpeg-devel mailing list