[FFmpeg-devel] [PATCH] FLAC parser

[Michael Chinen]

Hi,

Here is the new patch with these changes and one note:

On Mon, Aug 9, 2010 at 11:19 PM, Justin Ruggles
<justin.ruggles at gmail.com> wrote:
[...]
>> + ? ? ? ? ? ?/* Check sample and frame numbers. */
>> + ? ? ? ? ? ?if ((child->fi.frame_or_sample_num - header->fi.frame_or_sample_num
>> + ? ? ? ? ? ? ? ? != child->fi.blocksize) &&
>> + ? ? ? ? ? ? ? ?(child->fi.frame_or_sample_num
>> + ? ? ? ? ? ? ? ? != header->fi.frame_or_sample_num + 1)) {
>> + ? ? ? ? ? ? ? ? ? ?child_score -= FLAC_HEADER_CHANGED_PENALTY;
>> + ? ? ? ? ? ?}
>
>
> This is not correct. ?Should be:
> child sample num - header sample num = header blocksize
>
> Try testing with a variable blocksize sample.

Thanks for catching this!  I made the change but couldn't test it as I
have no FLAC files with variable block size, and ffmpeg and the
official flac tool don't support encoding them.

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-FLAC-Parser.patch
Type: application/octet-stream
Size: 38535 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100810/ac6f1e57/attachment.obj>