[FFmpeg-devel] Integrating the mod engine into FFmpeg - what is the best design approach?

Michael Niedermayer michaelni
Tue Aug 10 15:23:51 CEST 2010


On Mon, Aug 09, 2010 at 11:25:43AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Aug 9, 2010 at 8:46 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > A Audio decoder should return PCM. Doing something else is requireing all
> > applications that use libav to be changed. I dont see the point in going this
> > way
> 
> PCM what? Float is useless if the soundcard supports only int. The

a mod file contains pcm samples of instrunents that get modidifid and mixed
together to produce the final music.
that pcm you start out from has a type like 8bit, 16bit or float and this
is a good guess to what to output.


> idea was to use SAMPLE_FMT_something and wrap into audioconvert.c to
> do the actual sequencing to (and from?) PCM. 


> Applications would use
> audioconvert.c to convert between SAMPLE_FMT_* anyway, so it would

The majority of applications (in terms or users) id guess do not use
audioconvert.c
does mplayer, vlc, xine, ... ?

either way if your only argument is that the sample format cannot be choosen
optimally this is the same with all mdct codecs. and so no reason to handle
these differntly. Are you arguing that we should pass mdct coeffs to
audioconvert.c ?

also we have get_format() for video to select the pixel format if a decoder
can output multiple

Iam not opposed to change everything but iam opposed to handle mod differently
from mdct based codecs based on arguments that apply to both. This would be
inconsistent and inconsistent api is always annoying to work with


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100810/9a895ff2/attachment.pgp>



More information about the ffmpeg-devel mailing list