[FFmpeg-devel] [PATCH] FLAC parser

Michael Chinen mchinen
Thu Aug 12 02:34:05 CEST 2010


Hi,

Updated patch attached with one note:

On Wed, Aug 11, 2010 at 11:52 PM, Justin Ruggles
<justin.ruggles at gmail.com> wrote:
[...]
> As for the code duplication, maybe you could use something like this:
>
> static int check_header_mismatch(AVCodecContext *avctx,
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? FLACFrameInfo *header,
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? FLACFrameInfo *child,
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? int log_warning)

Thanks, this was a good idea and I refactored the code accordingly.  I
left out log_warning and just checked avctx for non-NULL instead.  If
we need to log to NULL contexts we can change it in the future, but
right now it doesn't do so.

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-FLAC-Parser.patch
Type: application/octet-stream
Size: 38837 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100812/86dba2fe/attachment.obj>



More information about the ffmpeg-devel mailing list