[FFmpeg-devel] [PATCH 1/1] Define macro AV_CODEC_ID_NE() and use it in alsa-audio.h.

Stefano Sabatini stefano.sabatini-lala
Tue Aug 17 16:41:00 CEST 2010


On date Monday 2010-08-16 18:22:43 -0400, Brad encoded:
> On Monday 16 August 2010 18:15:37 Stefano Sabatini wrote:
> > On date Thursday 2010-08-12 17:43:44 +0200, Stefano Sabatini encoded:
> > > Help further refactoring.
> >
> > Also OSS benefits from the macro, updated.
> > --
> > FFmpeg = Faithful & Fantastic Magnificient Portentous Exploitable Geisha
> 
> Instead of having DEFAULT_CODEC_ID in alsa-audio.h wouldn't it make more
> sense to push that back into alsa-audio-enc.c? It made sense in the header 
> with the ifdef but its a bit cleaner now to put it in alsa-audio-enc.c, no?

Separate patch, also DEFAULT_CODEC_ID is referenced in the code in
other points, so it requires a bit more adaptation.

Regards.
-- 
FFmpeg = Faithful and Formidable Mortal Peaceful ExchanGer



More information about the ffmpeg-devel mailing list