[FFmpeg-devel] [patch]add mmsh protocol and extract common code for mmst.c

Stefano Sabatini stefano.sabatini-lala
Fri Aug 20 16:13:06 CEST 2010


On date Friday 2010-08-20 21:42:57 +0800, zhentan feng encoded:
> Hi
> 
> On Fri, Aug 20, 2010 at 12:16 AM, Stefano Sabatini <
> stefano.sabatini-lala at poste.it> wrote:
> 
> > On date Thursday 2010-08-19 23:55:40 +0800, zhentan feng encoded:
> > [...]
> >
> > > +    snprintf(headers, sizeof(headers),
> > > +        "Accept: */*\r\n"
> > > +        USERAGENT
> > > +        "Host: %s:%d\r\n"
> > > +        "Pragma: no-cache,rate=1.000000,stream-time=0,"
> > > +        "stream-offset=0:0,request-context=%u,max-duration=0\r\n"
> > > +        CLIENTGUID
> > > +        "Connection: Close\r\n\r\n",
> > > +        host, port, mmsh->request_seq++);
> >
> > ditto
> >
> what's the problem with this item? The indent is 4 characters.
> I split into several lines for more readable as HTTP message type.

I mean:

    snprintf(headers, sizeof(headers),
             "Accept: */*\r\n"
             USERAGENT
             "Host: %s:%d\r\n"
             "Pragma: no-cache,rate=1.000000,stream-time=0,"
             "stream-offset=0:0,request-context=%u,max-duration=0\r\n"
             CLIENTGUID
             "Connection: Close\r\n\r\n",
             host, port, mmsh->request_seq++);

that is following params on the following lines are aligned to the
next character after "(".
  
> btw:I try to find the rule to follow according to ffprobe.c code style,
> but I am still not clear what's the NOT weird indent?
> could you explain it more?

Regards.
-- 
FFmpeg = Fascinating & Funny Mastodontic Puristic Explosive God



More information about the ffmpeg-devel mailing list