[FFmpeg-devel] [PATCH] add truemotion1 fate2 tests

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> On Sun, Aug 22, 2010 at 01:59:12PM +0100, M?ns Rullg?rd wrote:
>> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>> 
>> > On Sun, Aug 22, 2010 at 01:06:17PM +0100, M?ns Rullg?rd wrote:
>> >> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>> >> > I added two truemotion1 samples to fate2 tests, ok to apply?
>> >> > Should allow easy checking that everything works right on big-endian,
>> >> > and then it can be moved to regulare fate.
>> >> 
>> >> There is no distinction between "fate2" and "regular fate" anymore.
>> >
>> > Hm, how some other way to "stage" tests so they can easily be tested
>> > by others, preferably without extra knowledge?
>> > Something like attached maybe?
>> >
>> > Index: tests/fate.mak
>> > ===================================================================
>> > --- tests/fate.mak	(revision 24865)
>> > +++ tests/fate.mak	(working copy)
>> > @@ -302,6 +302,8 @@
>> >  fate-tiertex-seq: CMD = framecrc  -i $(SAMPLES)/tiertex-seq/Gameover.seq -pix_fmt rgb24
>> >  FATE_TESTS += fate-tmv
>> >  fate-tmv: CMD = framecrc  -i $(SAMPLES)/tmv/pop-partial.tmv -pix_fmt rgb24
>> > +fate-truemotion1-15: CMD = framecrc -i $(SAMPLES)/duck/phant2-940.duk -pix_fmt rgb24
>> > +fate-truemotion1-24: CMD = framecrc -i $(SAMPLES)/duck/sonic3dblast_intro-partial.avi -pix_fmt rgb24
>> >  FATE_TESTS += fate-tscc-15bit
>> >  fate-tscc-15bit: CMD = framecrc  -i $(SAMPLES)/tscc/oneminute.avi -t 15 -pix_fmt rgb24
>> 
>> That won't work, as you'd have noticed had you tried it.  Just add it
>> and let the FATE machines pick it up, but let a day pass between
>> adding the samples and committing the test rules.
>
> Well, it "works" in so far as reducing the enabling to a two-line change
> that doesn't require any knowledge of the actual test.
> However I guess it could be done more "properly" as in attached patch,
> if that's maybe a useful improvement?
> (without the ref files this time).
>
> Index: Makefile
> ===================================================================
> --- Makefile	(revision 24867)
> +++ Makefile	(working copy)
> @@ -277,8 +277,9 @@
>  
>  ifdef SAMPLES
>  FATE += $(FATE_TESTS)
> +FATE_ALL = $(FATE) $(DISABLED_FATE_TESTS)
>  else
> -fate2 $(FATE_TESTS):
> +fate2 $(FATE_TESTS) $(DISABLED_FATE_TESTS):
>  	@echo "SAMPLES not specified, cannot run FATE"
>  endif
>  
> @@ -287,7 +288,7 @@
>  fate: $(FATE)
>  fate2: $(FATE2_TESTS)
>  
> -$(FATE): ffmpeg$(EXESUF) $(FATE_UTILS:%=tests/%$(HOSTEXESUF))
> +$(FATE_ALL): ffmpeg$(EXESUF) $(FATE_UTILS:%=tests/%$(HOSTEXESUF))
>  	@echo "TEST    $(@:fate-%=%)"
>  	$(Q)$(SRC_PATH)/tests/fate-run.sh $@ "$(SAMPLES)" "$(TARGET_EXEC)" "$(TARGET_PATH)" '$(CMD)' '$(CMP)' '$(REF)' '$(FUZZ)'

I see no need for this.  Just add the test and be done with it.

-- 
M?ns Rullg?rd
mans at mansr.com