[FFmpeg-devel] [PATCH] yasm ff_imdct_half_sse

Alex Converse alex.converse
Sun Aug 22 16:42:36 CEST 2010


2010/8/22 M?ns Rullg?rd <mans at mansr.com>:
> Alex Converse <alex.converse at gmail.com> writes:
>
>> 2010/8/22 M?ns Rullg?rd <mans at mansr.com>:
>>> Alex Converse <alex.converse at gmail.com> writes:
>>>
>>>> On Wed, Aug 18, 2010 at 10:46 PM, Loren Merritt <lorenm at u.washington.edu> wrote:
>>>>>
>>>>> On Wed, 18 Aug 2010, Alex Converse wrote:
>>>>>
>>>>>> The attached patch ports the ff_imdct_half_sse function to
>>>>>> yasm. This wasn't done out of any desire for yasm purity. The
>>>>>> split asm sections were problematic on platforms where xmm
>>>>>> registers are callee saved (WIN64). It seems worthwhile to move
>>>>>> toward supporting out mdct audio decoders on WIN64. It also
>>>>>> gives fine grain control over exactly what spills when and and
>>>>>> reduces fft calling overhead.
>>>
>>> What's the holdup?
>>>
>>
>> Loren said CMUL could be more cleanly ordered.
>> I asked him to elaborate as I shamelessly stole the macro from him unchanged.
>
> Several days have passed, and he hasn't replied. ?IMO this should just
> be applied if that is the only issue. ?If he doesn't like it, he can
> "fix" it himself. ?Throwing out a cryptic complaint and then vanishing
> is not nice.
>

Applied



More information about the ffmpeg-devel mailing list