[FFmpeg-devel] [PATCH] Move CPU detection to libavutil and cleanup

Stefano Sabatini stefano.sabatini-lala
Tue Aug 24 10:19:40 CEST 2010


On date Tuesday 2010-08-24 00:21:08 +0100, M?ns Rullg?rd encoded:
> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
[...]
> > Updated with a less absurd name and with actually moving the code (not
> > only the declaration of the interface) from libavcodec to libavutil.
> >
> > I preferred to put all the code in a single cpuid.c file rather than
> > split the code in various x86/ppc/arm, also because this way it looked
> > simpler.
> 
> Arch-specific code goes in the arch dirs.  No discussion.

No problem.

> > FF_MM_* flags also maybe should be renamed something like:
> >
> > AV_CPU_MM_FLAG_*
> > or maybe:
> > AVCPU_MM_FLAG_*
> >
> > Please review it, regards.
> 
> Didn't we mostly agree on dropping the global mm_flags (used only in
> emms_c())?  A patch for that is underway as soon as it finishes
> testing here.  Getting rid of that global should reduce the size of
> this patch significantly.

I'll update this patch as soon as your patch will get applied.

Regards.
-- 
FFmpeg = Fiendish Fundamental Moronic Practical Egregious Gargoyle



More information about the ffmpeg-devel mailing list