[FFmpeg-devel] [PATCH] Move link_dpad and link_spad macros from avfilter.c to internal.h, so

[Stefano Sabatini]

On date Tuesday 2010-07-20 18:42:44 +0200, Michael Niedermayer encoded:
> On Mon, Jul 19, 2010 at 06:19:56PM +0200, Stefano Sabatini wrote:
> > ---
> >  libavfilter/avfilter.c |    4 ----
> >  libavfilter/internal.h |    4 ++++
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
> > index dc8f90d..e81fa48 100644
> > --- a/libavfilter/avfilter.c
> > +++ b/libavfilter/avfilter.c
> > @@ -41,10 +41,6 @@ const char *avfilter_license(void)
> >      return LICENSE_PREFIX FFMPEG_LICENSE + sizeof(LICENSE_PREFIX) - 1;
> >  }
> >  
> > -/** helper macros to get the in/out pad on the dst/src filter */
> > -#define link_dpad(link)     link->dst-> input_pads[link->dstpad]
> > -#define link_spad(link)     link->src->output_pads[link->srcpad]
> > -
> 
> iam against such obfuscation macros

So you either remove them or make them available in other files as
well.

Maybe the link_dstpad / link_srcpad names would read better?

As for me I surely find more readable:
AVFilterPad *pad = link_dstpad(link);
rather than:
AVFilterPad *pad = link->dst->input_pads[link->dstpad];

Regards.
-- 
FFmpeg = Fabulous and Fantastic Martial Practical Elastic Game