[FFmpeg-devel] [PATCH] Add libavsequencer.

[Måns Rullgård]

Sebastian Vater <cdgs.basty at googlemail.com> writes:

> M?ns Rullg?rd a ?crit :
>> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>>
>>   
>>> On date Wednesday 2010-08-25 00:55:04 +0200, Sebastian Vater encoded:
>>> [...]
>>>     
>>>> --- /dev/null
>>>> +++ b/libavsequencer/avsequencer.h
>>>> @@ -0,0 +1,54 @@
>>>> +/*
>>>> + * AVSequencer main header file which connects to AVFormat and AVCodec
>>>> + * Copyright (c) 2010 Sebastian Vater <cdgs.basty at googlemail.com>
>>>> + *
>>>> + * This file is part of FFmpeg.
>>>> + *
>>>> + * FFmpeg is free software; you can redistribute it and/or
>>>> + * modify it under the terms of the GNU Lesser General Public
>>>> + * License as published by the Free Software Foundation; either
>>>> + * version 2.1 of the License, or (at your option) any later version.
>>>> + *
>>>> + * FFmpeg is distributed in the hope that it will be useful,
>>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>>> + * Lesser General Public License for more details.
>>>> + *
>>>> + * You should have received a copy of the GNU Lesser General Public
>>>> + * License along with FFmpeg; if not, write to the Free Software
>>>> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>>>> + */
>>>> +
>>>> +#ifndef AVSEQUENCER_AVSEQUENCER_H
>>>> +#define AVSEQUENCER_AVSEQUENCER_H
>>>> +
>>>> +#define LIBAVSEQUENCER_VERSION_MAJOR 0
>>>> +#define LIBAVSEQUENCER_VERSION_MINOR 0
>>>> +#define LIBAVSEQUENCER_VERSION_MICRO 0
>>>> +
>>>> +#define LIBAVSEQUENCER_VERSION_INT AV_VERSION_INT(LIBAVSEQUENCER_VERSION_MAJOR, \
>>>> +                                                  LIBAVSEQUENCER_VERSION_MINOR, \
>>>> +                                                  LIBAVSEQUENCER_VERSION_MICRO)
>>>> +#define LIBAVSEQUENCER_VERSION     AV_VERSION(LIBAVSEQUENCER_VERSION_MAJOR,   \
>>>> +                                              LIBAVSEQUENCER_VERSION_MINOR,   \
>>>> +                                              LIBAVSEQUENCER_VERSION_MICRO)
>>>> +#define LIBAVSEQUENCER_BUILD       LIBAVSEQUENCER_VERSION_INT
>>>> +
>>>> +#define LIBAVSEQUENCER_IDENT       "Lavsequencer" AV_STRINGIFY(LIBAVSEQUENCER_VERSION)
>>>> +
>>>>       
>>>> +/**
>>>> + * Returns LIBAVSEQUENCER_VERSION_INT constant.
>>>> + */
>>>> +unsigned avsequencer_version(void);
>>>> +
>>>> +/**
>>>> + * Returns the libavsequencer build-time configuration.
>>>> + */
>>>> +const char *avsequencer_configuration(void);
>>>> +
>>>> +/**
>>>> + * Returns the libavsequencer license.
>>>> + */
>>>> +const char *avsequencer_license(void);
>>>>       
>>> Returns -> Return
>>>
>>> Looks OK otherwise, regards.
>>>     
>>
>> Pretty please, do not commit _anything_ related to this until a full,
>> functional set of patches has been presented and reviewed by several
>> people.
>>
>>   
>
> Hi Mans, I understand your point, but currently a) libavsequencer is
> disabled by default and b) is tagged as experimental.

That doesn't matter.  There is no point whatsoever in committing
something that may not survive even a cursory review once the rest is
presented.  In fact, doing so would be a VERY BAD THING.

> If I remember correctly, libavfilter got a similar way to get into SVN.

Nothing from libavfilter was committed before it was functional,
albeit optional.  By the time the first parts were committed to main
svn, it had been under development for well over a year, and there had
been numerous lengthy discussions about various aspects relating to
it.  In contrast, libavsequencer (or whatever the name of the week is)
strikes me as a rush job being rammed into svn without semblance of
proper review.