[FFmpeg-devel] [PATCH] Remove global mm_flags variable

Michael Niedermayer michaelni
Wed Aug 25 10:03:20 CEST 2010


On Wed, Aug 25, 2010 at 08:25:20AM +0200, Reinhard Tartler wrote:
> On Tue, Aug 24, 2010 at 21:44:55 (CEST), Michael Niedermayer wrote:
> 
> > On Tue, Aug 24, 2010 at 10:39:30PM +0300, Ivan Kalvachev wrote:
> >> On 8/24/10, Mans Rullgard <mans at mansr.com> wrote:
> >> > -
> >> > -#define emms_c() \
> >> > -{\
> >> > -    if (mm_flags & FF_MM_MMX)\
> >> > -        emms();\
> >> > -}
> >> > +#define emms_c() emms()
> >> 
> >> Michael, are you really OK with that change?
> >> The result would be illegal instruction on all pre-MMX CPUs.
> >
> > who still uses these?
> 
> I remember pretty prompt bugreports in both debian and ubuntu regarding
> non-mmx capable CPUs.

i ask again, who is still using these?
theres a big difference between people using ffmpeg on pre mmx hardware
and people running things in artifical or misconfigured environments
and possibly for no other purpose then to check if it runs on pre mmx
but not with the intent to use the software for any work.


> 
> Would that check be acceptable with --enable-runtime-cpudetect?

i dont volunteer to implement that


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100825/ff6bbcab/attachment.pgp>



More information about the ffmpeg-devel mailing list