[FFmpeg-devel] [PATCH] make building swscale rgb template conditional

[Alex Converse]

2010/8/25 M?ns Rullg?rd <mans at mansr.com>:
> Michael Niedermayer <michaelni at gmx.at> writes:
>
>> On Wed, Aug 25, 2010 at 09:59:54AM +0100, M?ns Rullg?rd wrote:
>>> Michael Niedermayer <michaelni at gmx.at> writes:
>>>
>>> > On Wed, Aug 25, 2010 at 09:50:23AM +0100, M?ns Rullg?rd wrote:
>>> >> Ramiro Polla <ramiro.polla at gmail.com> writes:
>>>
>>> [...]
>>>
>>> >> Why does libswscale have to be this disgustingly ugly? ?There's none
>>> >> of this ifdef hell in libavcodec, and it has many more different kinds
>>> >> of asm.
>>> >
>>> > thats because swscale has more features. like being able to be compiled
>>> > with just mmx2 code or just mmx code
>>>
>>> Libavcodec can be built with just Altivec or just NEON. ?Even for
>>> disabling selected x86 SIMD types, I don't see why such an enormous
>>> amount of ifdeffery should be needed.
>>
>> specific suggestions to improve it are welcome i guess
>
> I'd start with moving _all_ asm out of the main C files and into the
> x86 subdir. ?Then I'd try to get rid of much of the RENAME() tangle.
>

Agreed. x86 specific code should not live outside of the x86 directory.