[FFmpeg-devel] [PATCH 1/2] Rename FF_MM_ symbols related to MultiMedia CPU features as AV_CPU_MM_ symbols, as they are public, and move them from libavcodec/avcodec.h to libavutil/cpu.h.

Luca Barbato lu_zero
Mon Aug 30 03:17:46 CEST 2010


On 08/30/2010 01:27 AM, Stefano Sabatini wrote:
> On date Sunday 2010-08-29 23:59:35 +0100, M?ns Rullg?rd encoded:
>> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> [...]
>>> --- a/libavcodec/arm/dsputil_init_arm.c
>>> +++ b/libavcodec/arm/dsputil_init_arm.c
>>> @@ -75,7 +75,7 @@ static void simple_idct_arm_add(uint8_t *dest, int line_size, DCTELEM *block)
>>>
>>>  int mm_support(void)
>>>  {
>>> -    return HAVE_IWMMXT * FF_MM_IWMMXT;
>>> +    return HAVE_IWMMXT * AV_CPU_MM_IWMMXT;
>>>  }
>>
>> Is the MM part really needed?
> 
> Are not those flags related to MultiMedia extensions?

Most if not all are just simd instructions set that happen to be handy
when doing multimedia, I'd drop that MM.

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero




More information about the ffmpeg-devel mailing list