[FFmpeg-devel] port mplayer eq filter to libavfilter

Ronald S. Bultje rsbultje
Tue Dec 7 03:40:00 CET 2010


Hi,

On Mon, Dec 6, 2010 at 9:00 PM, William Yu <genwillyu at gmail.com> wrote:
> 2010/12/4 Michael Niedermayer <michaelni at gmx.at>:
>> On Fri, Dec 03, 2010 at 02:47:58AM +0100, Michael Niedermayer wrote:
>> [...]
>>>
>>> > +
>>> > + ? ?__asm__ volatile (
>>> > + ? ? ? ?"movd %3, %%mm3 \n\t"
>>> > + ? ? ? ?"movd %4, %%mm4 \n\t"
>>> > + ? ? ? ?"punpcklwd %%mm3, %%mm3 \n\t"
>>> > + ? ? ? ?"punpcklwd %%mm4, %%mm4 \n\t"
>>> > + ? ? ? ?"punpckldq %%mm3, %%mm3 \n\t"
>>> > + ? ? ? ?"punpckldq %%mm4, %%mm4 \n\t"
>>> > + ? ? ? ?"1: \n\t"
>>> > + ? ? ? ?"pxor %%mm0, %%mm0 \n\t"
>>> > + ? ? ? ?"mov %2, %%"REG_c" \n\t"
>>> > + ? ? ? ?"sar $3, %%"REG_c" \n\t"
>>> > + ? ? ? ?"2: \n\t"
>>> > + ? ? ? ?"movq (%0), %%mm1 \n\t"
>>>
>>> > + ? ? ? ?"movq %%mm1, %%mm2 \n\t"
>>>
>>> have you benchmarked changeing this one from mplayer?
>>
>> note, you can trivially benchmark code by putting START/STOP_TIMER around
>> code that you want to benchmark
>>
>
> Thanks for your help. I optimizing it.
> Should i revert assembly code to original mplayer code
> before i can finding out a better way?

No, just compare the two versions of the complete function with this
one line changed only, and send us whichever of the two is faster.

Ronald



More information about the ffmpeg-devel mailing list