[FFmpeg-devel] [PATCH]: One line fix for https://roundup.ffmpeg.org/issue2343

Joey Geralnik jgeralnik
Fri Dec 10 00:40:45 CET 2010


Sorry, I didn't realize the function was doing something in addition to
returning a result. The result doesn't need to be saved since ret is
overwritten in the next line. Tested current patch with
http://samples.mplayerhq.hu/MPEG-4/MPEG4%20by%20philips.mp4
--Joey


On Fri, Dec 10, 2010 at 1:12 AM, Alexander Strange <astrange at ithinksw.com>wrote:

>
> On Dec 9, 2010, at 6:02 PM, Joey Geralnik wrote:
>
> > --Joey
>
> No, that just breaks any MPEG4 .mp4 file. Check the return value.
>
> > <submission.diff>_______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at mplayerhq.hu
> > https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: submission2.diff
Type: text/x-patch
Size: 536 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101210/a1b5440d/attachment.bin>



More information about the ffmpeg-devel mailing list