[FFmpeg-devel] [PATCH]: One line fix for https://roundup.ffmpeg.org/issue2343

[Jason Garrett-Glaser]

On Thu, Dec 9, 2010 at 8:05 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Thu, Dec 09, 2010 at 05:06:05PM -0800, Jason Garrett-Glaser wrote:
>> On Thu, Dec 9, 2010 at 3:58 PM, Joey Geralnik <jgeralnik at gmail.com> wrote:
>> > Um, yes, it is silly to file a bug with the solution built into the question
>> > but if it is already filed might as well patch it.
>> > --Joey
>>
>> 1. ?Stop top-posting.
>>
>> 2. ?Read my message again and again until you understand why your
>> patch does literally the exact opposite of fixing the problem.
>
> i dont want to disturb your discussion but,
> what problem?
> a bug involves user vissible (wrong) behavior.
> What kind of wrong behavior does this cause?

As far as I can tell, the bug is that the error code doesn't get
checked.  Therefore, an error could occur in the function as a result
of failed parsing, but then be ignored, causing ffmpeg to continue
parsing anyways even when it shouldn't.

Jason