[FFmpeg-devel] [PATCH] Windows Television (.wtv) demuxer

Michael Niedermayer michaelni
Tue Dec 21 00:06:42 CET 2010


On Mon, Dec 20, 2010 at 05:22:18PM +1100, Peter Ross wrote:
> On Wed, Dec 01, 2010 at 01:30:45AM +0100, Michael Niedermayer wrote:
> > On Sat, Nov 27, 2010 at 08:20:18PM +1100, Peter Ross wrote:
> > > Bump. Minor patch update:
> > >     Support MPEG Layer 1/2/3 (MPEG1WAVEFORMATEX)
> > >     Associate some names with the unknown GUIDs
> > > 
> > > On Sat, Nov 13, 2010 at 03:05:49PM +1100, Peter Ross wrote:
> > > > Updated patch set. Improvements:
> > > >     demuxer now ignores unsupported streams
> > > >     placeholder streams are also ignored
> > > >     use metadata 'language' tag
> > > >     added AC3 GUID
> > > 
> > > -- Peter
> > > (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
> > 
> > [...]
> > > +static int find_stream_index(AVFormatContext *s, int id)
> > > +{
> > > +    int i;
> > > +    for (i = 0; i < s->nb_streams; i++) {
> > > +        if (s->streams[i]->id == id)
> > > +            return i;
> > > +    }
> > > +    return -1;
> > > +}
> > 
> > can be factored with   get_sindex() of gxf.c
> 
> Enclosed.
> 
> -- Peter
> (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

>  gxf.c |   17 +++++++++++++----
>  gxf.h |    2 ++
>  2 files changed, 15 insertions(+), 4 deletions(-)
> 5b91b8585d47c46900bc9a80eae486ee424863bf  ff_find_stream_index.diff
> diff --git a/libavformat/gxf.c b/libavformat/gxf.c
> index af2ee9d..aa089ea 100644
> --- a/libavformat/gxf.c
> +++ b/libavformat/gxf.c
> @@ -68,6 +68,16 @@ static int gxf_probe(AVProbeData *p) {
>      return 0;
>  }
>  
> +int ff_find_stream_index(AVFormatContext *s, int id)
> +{
> +    int i;
> +    for (i = 0; i < s->nb_streams; i++) {
> +        if (s->streams[i]->id == id)
> +            return i;
> +    }
> +    return -1;
> +}

i think this should be in utils.c, also feel free to just commit no need for a
patch

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101221/43584745/attachment.pgp>



More information about the ffmpeg-devel mailing list