[FFmpeg-devel] [RFC] How to fix DR+lavfi+vflip crash

Michael Niedermayer michaelni
Tue Dec 28 22:49:30 CET 2010


On Tue, Dec 28, 2010 at 11:34:53AM +0100, Stefano Sabatini wrote:
> On date Tuesday 2010-12-28 05:00:36 +0100, Michael Niedermayer encoded:
> > On Mon, Dec 27, 2010 at 10:43:32PM -0500, Ronald S. Bultje wrote:
> [...]
> > > Can we please force 16-byte alignment on buffers allocated within lav*?
> > 
> > We already have that except when pad/crop is used.
> > for them 16byte alignment means memcpy if their parameters arenr multiple of
> > 16
> > we should be able to handle this easily with adding some flag in line of
> > negative linesizes thus avoiding the copy when the next filter doesnt need
> > alignment.
> 
> Yes that was my idea, and we could have a fast version of the crop/pad
> filters (crop16/pad16) which always align the returned buffers by 16.

no, there will be just one pad and one crop.
the code needed for this is trivial

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101228/5f38fae3/attachment.pgp>



More information about the ffmpeg-devel mailing list