[FFmpeg-devel] [PATCH] Windows support for av_file_map()

[Michael Niedermayer]

On Fri, Dec 31, 2010 at 08:37:00PM +0100, Reimar D?ffinger wrote:
> On 31 dec 2010, at 20:26, Daniel Verkamp <daniel at drv.nu> wrote:
> 
> > On Fri, Dec 31, 2010 at 8:51 AM, Reimar D?ffinger
> > <Reimar.Doeffinger at gmx.de> wrote:
> >> On Fri, Dec 31, 2010 at 02:35:50AM -0700, Daniel Verkamp wrote:
> >>> This currently maps a read-only view of the file; this could be
> >>> changed to R/W to match the mmap() path if desired, but any code
> >>> expecting to actually use it for writing will fail with the non-mmap()
> >>> path anyway since the file is never written back in that case.
> >> 
> >> What? Why would it not be written back?
> > 
> > In the malloc() case is what I meant - av_file_unmap() simply frees the buffer.
> 
> Even that could keep the file open and write the changes back before free - assuming the API was designed in a sane way that allows storing size and offset for use in that function.

I think the forced av_log useage and dependancy is a bigger problem than the
lack of write support.

[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20101231/31de62e6/attachment.pgp>