[FFmpeg-devel] [PATCH] fix stream copy

Michael Niedermayer michaelni
Mon Feb 1 20:16:39 CET 2010


On Mon, Feb 01, 2010 at 07:53:54PM +0100, Michael Niedermayer wrote:
> On Fri, Jan 29, 2010 at 03:01:20PM -0800, Baptiste Coudurier wrote:
> > On 01/27/2010 01:47 AM, Maksym Veremeyenko wrote:
> >> Baptiste Coudurier ???????(??):
[...]
> 
> >
> > With your patch the definition would become wrong in some cases.
> >
> >>>
> >>> One other possible solution is to use pts.val when stream copy is used.
> >>>
> >> it will require changing another part of code where ost->sync_opts used
> >> for stop condition or keep previous packet pts to calc duration of
> >> previous packet....
> >>
> >
> > Hummm, I'm not sure what you mean, but this seems to fix the issue for me. 
> > Can you confirm ?
> >
> > The idea is to only use sync_opts if the codec time base of the output 
> > looks like a frame rate.
> >
> > Michael what do you think ? I'm not sure why video is treated separately.
> 
> i think audio should use sync_opts as well, but this will need some minor
> changes i suspect

changed my mind, is there a reason why you did not just drop the sync_opts
case for video andmake it use what audio does?
ill probably commit that very soon unless i notice some breakage

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100201/33bf4bed/attachment.pgp>



More information about the ffmpeg-devel mailing list