[FFmpeg-devel] [PATCH] Indeo 5 decoder

[Michael Niedermayer]

On Wed, Feb 03, 2010 at 10:02:33PM +0200, Kostya wrote:
> On Wed, Feb 03, 2010 at 08:39:01PM +0100, Maxim wrote:
> > pross at xvid.org schrieb:
> > > On Mon, Feb 01, 2010 at 09:17:41AM +0200, Kostya wrote:
> > >   
> > >> $subj
> > >>     
> > >
> > >   
> > >> +/**
> > >> + * @file libavcodec/indeo5data.h
> > >> + * This file contains data needed for the Indeo5 decoder.
> > >> + */
> > >> +
> > >> +#ifndef AVCODEC_INDEO5DATA_H
> > >> +#define AVCODEC_INDEO5DATA_H
> > >> +
> > >> +#include <stdint.h>
> > >> +
> > >> +/**
> > >> + *  standard picture dimensions (width, height)
> > >> + */
> > >> +static uint16_t ivi5_common_pic_sizes[30] = {640, 480, 320, 240, 160, 120, 704, 480, 352, 240, 352, 288, 176, 144,
> > >> +                                             240, 180, 640, 240, 704, 240,  80,  60,  88,  72,   0,   0,   0,   0, 0, 0};
> > >>     
> > >
> > > these would fit in uint8_t if you divided everyting by 4.
> > >   
> > 
> > Sorry guys, but I think it would make the code less readable IMHO. I
> > don't see much sense in obfuscating this tiny table in order to save 30
> > bytes of memory...
> > Plz don't be angry, it's just my opinion...
> 
> It's not a big issue anyway. I'd like to have a review though, so I can
> correct it and have one entry less in FFmpeg 0.6 checklist ;)

optimiztaion, bugfixes, new features, flames, and reviewing patches
is too much all together for me.
So i will likely leave review of this patche to someone else

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100204/0b0fc65b/attachment.pgp>