[FFmpeg-devel] [PATCH] improvement on r21598 ("fix stream copy")

[Michael Niedermayer]

On Sat, Feb 06, 2010 at 09:51:22PM -0000, Wolfram Gloger wrote:
> Hi,
> 
> When using ffmpeg -t, after r21598:
> 
> +        /* finish if recording time exhausted */
> +        if (pkt.pts * av_q2d(ist->st->time_base) >= (recording_time / 1000000.0))
> +            goto discard_packet;
> 
> the test near line ffmpeg.c:2254: 
> 
>          /* finish if recording time exhausted */
>          if (opts_min >= (recording_time / 1000000.0))
>              break;
> 
> doesn't trigger anymore, because no packets with opts_min larger than
> recording time are ever output (they are just discarded -- like they
> should be).
> 
> So, everything still works correctly, but all input files are
> needlessly read until EOF, and there are also timestamp discontinuity
> warnings output every ten seconds.  How about the appended patch?
> 
> Regards,
> Wolfram.

>  ffmpeg.c |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 793cbe919fc870f436e46b3ada8ce995cb1f6eb4  ffmpeg-past-recording-time.diff

ok if tested

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Incandescent light bulbs waste a lot of energy as heat so the EU forbids them.
Their replacement, compact fluorescent lamps, much more expensive, dont fit in
many old lamps, flicker, contain toxic mercury, produce a fraction of the light
that is claimed and in a unnatural spectrum rendering colors different than
in natural light. Ah and we now need to turn the heaters up more in winter to
compensate the lower wasted heat. Who wins? Not the environment, thats for sure
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100207/d66cdc51/attachment.pgp>