[FFmpeg-devel] [PATCH] asfenc: fix extended content header

Michael Niedermayer michaelni
Mon Feb 15 18:31:01 CET 2010


On Mon, Feb 15, 2010 at 05:57:25PM +0100, Anton Khirnov wrote:
> Hi,
> currently asfenc writes string length in extended content header
> assuming terminating NULL is one byte, while it should be 2. this breaks
> demuxing of all asf files with extended content header.
> 
> Anton Khirnov
> 

>  asfenc.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 94f9c6eb4f55fb334e75f9beb4a159f502b75258  0001-asfdec-strings-in-extended-content-header-are-UTF16-.patch
> From 2ce78ef109e85524801aa2842550deed9758bf3c Mon Sep 17 00:00:00 2001
> From: Anton Khirnov <wyskas at gmail.com>
> Date: Mon, 15 Feb 2010 16:53:13 +0100
> Subject: [PATCH] asfdec: strings in extended content header are UTF16, so terminating
>  NULLs are 2 bytes long, not 1.

ok assuming regression tests pass
also i assume our demuxer can read both the correct and broken
variant?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100215/b650aed5/attachment.pgp>



More information about the ffmpeg-devel mailing list