[FFmpeg-devel] [PATCH] Fix inclusion in pixdesc.h of the non-public header intreadwrite.h

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Mon, Feb 15, 2010 at 06:37:19PM +0000, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>> 
>> > On Mon, Feb 15, 2010 at 01:00:42PM +0000, M?ns Rullg?rd wrote:
>> >> Michael Niedermayer <michaelni at gmx.at> writes:
>> >> 
>> >> > On Sun, Feb 14, 2010 at 11:39:35PM +0100, Stefano Sabatini wrote:
>> >> >> Hi all,
>> >> >> 
>> >> >> intreadwrite.h is not public so we should not include it in a public
>> >> >> header, this also fixes a bunch of warnings during compilation.
>> >> >> 
>> >> >> Also read_line() and write_line() are just meant for
>> >> >> testing/debugging/pedagogical purposes, so the fact that they're not
>> >> >> defined inline shouldn't be relevant.
>> >> >
>> >> > no, read/write_line() are an essential and important part of
>> >> > pixdescs They where intended as fallback for very rarely used
>> >> > convertions in swscale having a specific optimized converter
>> >> > for each pixel format is overkill especially on CONFIG_SMALL
>> >> > targets
>> >> 
>> >> Having them inline in the public header doesn't exactly fit with that
>> >> description, so I think the patch is fine.  No functionality is being
>> >> removed.
>> >
>> > well, if its important to you then iam ok with moving them to the c file
>> >
>> > but i still do want intreadwrite public ...
>> 
>> That's a different debate.
>> 
>> > it is usefull and used
>> 
>> That's impossible.
>
> in mplayer trunk
> grep 'AV_R[BL][0-9]' *.{c,h} libmp*/*.{c,h} |wc
>     108     564    7751

For the billionth time: intreadwrite.h is IMPOSSIBLE TO WRITE
PORTABLY.  MPlayer abuse is totally irrelevant.

> not to mention libavcodec & avformat are also different libs than libavutil

They are built together, using the same compiler.  Following that line
of reasoning, all the compiler/arch-specific bits in lavu should be
moved to lavc and lavf be damned.

-- 
M?ns Rullg?rd
mans at mansr.com