[FFmpeg-devel] [PATCH] ffprobe integration

Stefano Sabatini stefano.sabatini-lala
Tue Feb 16 20:58:33 CET 2010


On date Tuesday 2010-02-16 20:18:11 +0100, Michael Niedermayer encoded:
> On Tue, Feb 16, 2010 at 01:04:04AM +0100, Stefano Sabatini wrote:
> > On date Monday 2010-02-15 02:22:09 +0100, Michael Niedermayer encoded:
> > > On Mon, Feb 15, 2010 at 12:59:13AM +0100, Stefano Sabatini wrote:
> > [...]
> > > > +/* globals */
> > > > +static const OptionDef options[];
> > > > +
> > > > +/* FFprobe context */
> > > > +static const char *input_filename;
> > > > +
> > > > +static const char *binary_unit_prefixes[] = { "", "Ki", "Mi", "Gi", "Ti", "Pi" };
> > > 
> > > > +static const int binary_unit_prefixes_nb = FF_ARRAY_ELEMS(binary_unit_prefixes);
> > > 
> > > please use FF_ARRAY_ELEMS() directly
> > > 
> > > 
> > > [...]
> > > 
> > > > +static char *time_value_string(char *buf, int buf_size, int64_t val, AVRational *time_base)
> > > 
> > > time_base should be const if you pass it as pointer
> > > 
> > > 
> > > [...]
> > > > +    printf("size=%s\n",             value_string(val_str, sizeof(val_str), (double)fmt_ctx->file_size,
> > > > +                                                 unit_byte_str));
> > > 
> > > useless cast
> > 
> > Fixed.
> > 
> > Also performed some move-around and added some notes in the
> > documentation.
> 
> no more comments from me, the issues that bothered me, you have addressed.

Excellent, I'll wait few days then I'll apply if there are no other
comments.

Then I'll try to port the other features currently implemented in SF
ffprobe (-show_packets, -show_frames) and will try to address some of
the issues raised by Ramiro.

Regards.
-- 
FFmpeg = Funny Funny Magic Power Everlasting God



More information about the ffmpeg-devel mailing list